fix: use PowerMemError instead of generic Error in NativeProvider.update#9
Merged
Evenss merged 1 commit intoob-labs:mainfrom Apr 7, 2026
Merged
Conversation
NativeProvider.update() threw a plain Error when the memory ID was not found, making it impossible for callers to distinguish domain errors via instanceof PowerMemError. Align with the project's custom error hierarchy by throwing PowerMemError with code 'NOT_FOUND'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NativeProvider.update()threw a plainErrorwhen the memory ID was not found, making it impossible for callers to catch domain errors viainstanceof PowerMemErrorPowerMemErrorusing code'NOT_FOUND', aligning with the project's custom error hierarchyPowerMemErrortypeChanges
src/core/native-provider.ts: importPowerMemError, replacethrow new Error(...)withthrow new PowerMemError(..., 'NOT_FOUND')tests/integration/coverage-gaps.test.ts: addtoBeInstanceOf(PowerMemError)assertiontests/regression/edge-cases.test.ts: addtoBeInstanceOf(PowerMemError)assertions for both invalid ID casesTest plan
instanceof PowerMemError'Memory not found: <id>')