Skip to content

Conversation

@camachat
Copy link

Fix compiling by QNX 7 SDK.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Feb 29, 2024

Thanks for adding in QNX platform support. However the way that you have raised this PR is likely to cause some downstream issues.

The 2 additional merges 'Merge branch ...' need to be removed as as they will add in unnecessary log entries into the obgm/develop branch. Whenever a third-party PR is merged into the obgm/develop branch, github automatically does a rebase of PR with the the obgm/develop branch, and assuming the rebase has no issues the PR merge goes to completion. However, as can be seen in #329, github will not allow a PR to get merged if there are any rebase issues with obgm/develop.

The branch of your PR should not be develop, but have some other relevant descriptive name (such as qnx_support).

I suggest that you follow the guidelines as per https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/configuring-a-remote-repository-for-a-fork , and https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork for managing your fork of obgm/develop. It is always best to leave the develop branch as an identical copy of the develop branch of obgm/develop )even if it is a commits behind). Then if your develop branch gets rebased against obgm/develop, it will still be identical.

I would prefer the commit title to be "QNX: Add platform support" to help future users work out what has been done here.

@mrdeep1
Copy link
Collaborator

mrdeep1 commented Mar 6, 2024

Changes cleaned up and PR created as #1339 for merging.

@mrdeep1 mrdeep1 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants