Merged
Conversation
✅ Deploy Preview for cynic-querygen-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Owner
|
Nice. Hadn't seen these warnings yet myself, think I'm still running a fairly old rust w/ cynic. Good to fix them though - thanks @Ten0 |
Contributor
Author
|
NB: wanted to start working on a PR but it turned out that the actual issue was TedDriggs/darling#263, so no extra PR to come 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to start working on a PR but my VSCode reported some of warnings with the current code.
It looks like Rust has recently improved their unused code diagnosis, where before if something was
pubbut unused within the crate and not reexported outside of the crate it wouldn't show the warning, and now it does.