waited for all pods ready during generated hashring initialization#138
Closed
christopherzli wants to merge 2 commits intoobservatorium:mainfrom
Closed
waited for all pods ready during generated hashring initialization#138christopherzli wants to merge 2 commits intoobservatorium:mainfrom
christopherzli wants to merge 2 commits intoobservatorium:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the initial controller setup, we prefer to wait over all pods ready before generating hashring.
controller will wait for all pods ready before generating hashring for first time if using allow only read replicas.
if not all pods are ready, it will be no-op if not all pods are ready and replicas do not exist in the local controller.
This is to handle no replicas information stored in local controller after controller restarts, we should not do anything until the cluster is healthy.