Update CMake #60
Update CMake #60
Conversation
CMakeLists.txt
Outdated
| set(CMAKE_CXX_VISIBILITY_PRESET hidden) | ||
| set(CMAKE_VISIBILITY_INLINES_HIDDEN TRUE) | ||
|
|
||
| set( |
There was a problem hiding this comment.
If we're in the process of effectively rewriting this file, then we should use target_sources directly and just move the library definition further up.
CMakeLists.txt
Outdated
| # Disable pointless constant condition warnings | ||
| target_compile_options(libdshowcapture PRIVATE /W4 /wd4127 /wd4201) | ||
|
|
||
| if(NOT CMAKE_SIZEOF_VOID_P EQUAL 8) |
There was a problem hiding this comment.
Would probably make sense to explicit check the VS generator platform here and check explicitly for x86/x64/arm64 here.
There was a problem hiding this comment.
Updated.
From the documentation, /SAFESEH is only valid when linking for x86 targets, so I think this is the platform where we override it to be /SAFESEH:NO to make sure all platforms do not use SAFESEH.
* Update to C/C++17 * Use targets instead of global set and add calls * Assume WIN32 is always the target platform * Replace CMake 2.x with CMake 3.x compile language and ID checks * Remove unnecessary FindCXX11 module
Done. |
Description
This PR consists of three commits to make it easier to differentiate between the intended changes. The commits will be squashed, or the second commit can be dropped if we intend to keep support for non-MSVC compilers/toolchains.
Modernize the project's CMake:
Updating to C/C++17 is required due to code in the capture-device-support submodule using C++17 features.
Remove support for non-MSVC compilers.
Since libdshowcapture is a Windows-only library, supporting GCC, Clang, and MinGW adds extra complication that we otherwise would not have to handle if we only support MSVC. This could be added back in the future if there is a reasonable justification for it.
Reformat CMake with gersemi
This matches the CMake formatting preferences in obs-studio.
Motivation and Context
The CMake currently in the repo fails to configure. I figured this was a good opportunity to do some cleanups. This could probably go further, and I do additionally intend to remove the
vsfolder containing the solution and project files. For now, I wanted to get this off of my local machine and placed here for public comment/review.How Has This Been Tested?
Tested locally on Windows 11. The CMake configures, generates a solution, and the solution can be built with VS2022.
You should be able to configure and generate a solution with:
Then you should be able to open the solution and build it with Visual Studio, or build it via CLI with CMake:
As far as I know, obs-studio itself does not use this repo's CMake, so these changes should not affect usage there.
Types of changes
Checklist: