Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs-webrtc: Default H264 profile to main if unset #10827

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sean-Der
Copy link
Contributor

@Sean-Der Sean-Der commented Jun 11, 2024

Description

If user requests a specific H264 profile respect it, otherwise default to main.

Motivation and Context

OBS defaults to H264 settings that aren't supported by browsers. This requires all WebRTC users to set advanced settings by default.

This is a frequent debugging topic by users on discord. I had 3 different users who were inconvenienced because of this behavior.

The new beta release of OBS was also tested by QA at Twitch. The 'WebRTC tests' were marked as failed because of the current behavior. We had to re-run the tests and ask to explicitly set the H264 profile.

How Has This Been Tested?

I have tested locally with X264, QSV, nvenc and AOM AV1 on Windows.

On discord 3 users have been testing. Will link ticket so they can provide feedback.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Resolves #10821

If user requests a specific H264 profile respect it, otherwise default
to main.
@WizardCM WizardCM added the Enhancement Improvement to existing functionality label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obs-webrtc should default to main profile
2 participants