obs-webrtc: Default H264 profile to main if unset #10827
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If user requests a specific H264 profile respect it, otherwise default to main.
Motivation and Context
OBS defaults to H264 settings that aren't supported by browsers. This requires all WebRTC users to set advanced settings by default.
This is a frequent debugging topic by users on discord. I had 3 different users who were inconvenienced because of this behavior.
The new beta release of OBS was also tested by QA at Twitch. The 'WebRTC tests' were marked as failed because of the current behavior. We had to re-run the tests and ask to explicitly set the H264 profile.
How Has This Been Tested?
I have tested locally with X264, QSV, nvenc and AOM AV1 on Windows.
On discord 3 users have been testing. Will link ticket so they can provide feedback.
Types of changes
Checklist:
Resolves #10821