Fix NAL type for HEVC caption/BPM SEIs #12658
Open
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes NAL type for caption/bpm SEIs from prefix to suffix.
Motivation and Context
We add the SEIs at the end of the packet, so making them prefix NALs is not spec compliant. This causes errors with some decoders.
See 7.4.2.4.4 Order of NAL units and coded pictures and their association to access units in the H.265 specification:
How Has This Been Tested?
Streamed with captions, no longer crashes playback on Qualcomm phones, yay.
Types of changes
Checklist: