Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address a couple miscellaneous issues #21

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Address a couple miscellaneous issues #21

merged 3 commits into from
Oct 20, 2022

Conversation

ahlec
Copy link
Collaborator

@ahlec ahlec commented Oct 16, 2022

This PR focuses on fixing up a couple of tiny issues:

  • Add the same file header to each file. I created some new files, but didn't copy over the license header. I've added or changed the file header for every Python file to match now;
  • Changed mecab.arm file permissions. Whenever I run the plugin on an M1 Mac, it changes the permissions for this file, which produces a git change. I committed this change so that developers don't need to see this change when running their code.
    • /support/mecab is already at this -rwxr-xr-x permission level, so it felt OK to commit this
  • Fixed the mypy errors in all of the files. There were a couple of linting errors in the source files, mostly around typing. I've updated these to make the errors go away.

I've tested these changes on both Anki 2.1.54 and Anki 2.1.49.

Also, I wasn't sure (this is my first open-source project) if I should continue to maintain my fork, or push branches on this one now that I'm a contributor. If it wasn't OK for me to push to this repo, I'll continue to use my fork for any future work!

@obynio
Copy link
Owner

obynio commented Oct 20, 2022

Hello, sorry for the late answer. Yeah seems like good changes, we can merge that !

this is my first open-source project

Well as far as I can see you make quality contributions !
It's a small open-source project but what matters is the fun we get doing it 🙂

Also I wasn't sure if I should continue to maintain my fork, or push branches on this one now that I'm a contributor.

You can push branches here or use your own project. Choose what's the more convenient for you 👍

@obynio obynio merged commit 1bd295e into master Oct 20, 2022
@obynio obynio deleted the cleanup branch October 20, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants