Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python-programming-advanced.ipynb unit test #336

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

penjc
Copy link
Contributor

@penjc penjc commented May 30, 2023

Description

Modified part of the code. All modified code is generated by gpt. Add unit tests.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have applied tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@penjc
Copy link
Contributor Author

penjc commented May 31, 2023

All done.

@penjc penjc closed this May 31, 2023
@penjc penjc reopened this May 31, 2023
@penjc penjc changed the title Update advanced assignment Update python-programming-advanced.ipynb unit test May 31, 2023
@@ -14,6 +14,8 @@
"MIT License\n",
Copy link
Contributor

@zhangqi444 zhangqi444 Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyright should be in 3 lines.


Reply via ReviewNB

@@ -14,6 +14,8 @@
"MIT License\n",
Copy link
Contributor

@zhangqi444 zhangqi444 Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    import unittest

Please revert this. Each PR should only focus on one thing. You can add UT in a later PR. Also, the format here is incorrect.


Reply via ReviewNB

@zhangqi444
Copy link
Contributor

You can resolve the comments in your next PR.

@zhangqi444 zhangqi444 merged commit f61b0d9 into ocademy-ai:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants