Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower dune requirement? #212

Closed
jordwalke opened this issue Jul 2, 2020 · 3 comments · Fixed by #218
Closed

Lower dune requirement? #212

jordwalke opened this issue Jul 2, 2020 · 3 comments · Fixed by #218

Comments

@jordwalke
Copy link

I noticed that the master branch of omd has "dune" {>= "2.5"}

Is there a reason why this is needed?

It makes it more difficult for some packages or internal systems that have to be pinned to an earlier version of Dune, just as one example. Is there something really advanced going on in the build that requires >=2.5?

@nojb
Copy link
Contributor

nojb commented Jul 2, 2020

I will check. Which version would be OK for you?

@nojb
Copy link
Contributor

nojb commented Jul 5, 2020

I made #218, requiring only dune 2.0. Going lower than that would be a bit more work and I would rather not, since dune 1.0 is not actively maintained anymore and lacks some features that we are currently using.

Does this work for you? Thanks!

@shonfeder
Copy link
Collaborator

shonfeder commented Sep 26, 2021

Just FYI, @jordwalke: we are planning to update dune to 2.7. That is still 2 minor versions behind the latest, and 3.0 is on the horizon, so I think it is reasonable for us to be looking forward to the latest.

I'll give that PR (#255) a day or two in case any discussion around it is needed, but I assume that if a project is able to get by pinning their dune version to =< 2.0 the can accommodate by pinning omd to a suitable version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants