Add regression test for #224 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use dune's built in cram testing, instead of the bespoke cram-style testing that used for the spec. I think it makes sense to support the current finicky testing setup for the spec, because it lets us use the commonmark spec as a raw source of truth, but for further tests we add I think we'll benefit from a more lightweight set up. Since we are already using dune, it seems sensible to use this testing framework we get access to with a two line change. We might consider reworking the spec testing setup to generate dune-supported cram tests in the future tool, as it would eliminate a good chunk of code.
|
I think relying on the dune cram-test support is a good thing. |
sonologico
approved these changes
Sep 27, 2021
|
Excellent. Thanks, @sonologico ! The windows CI failures are due to an ongoing issue with the |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #224
This also bumps our dune lang version up to 2.7, which reverses course from #218, originally motivated by #212.
See c3d151e for the rationale.
This bears upon one aspect of the testing question that came up at #248. @sonologico how do you feel about adopting Dune's built in support for cram-style tests, as I'm doing here, for our end-to-end testing setup?