Update to the Documentation Site #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
added
documentation
no-changelog-needed
n-osborne
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Thanks!
- First commit message: Updated -> Update
- The second commit contains an update of node version while it is about updating the content of the documentation
I haven't investigated the incompatibility reported by the CI when trying to build the documentation.
Apart from that, I obviously agree with the change.
|
Ok I fixed the issues you pointed out. With regards to incompatibility, I think if you change the node version on the Gospel side it will work. |
|
It seems that if you update the Regarding 1b15126, it is cleaner to use |
|
Ok, I fixed the merge commit and changed the node version on the |
|
Excellent! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I was analyzing the Gospel documentation website and as I was exploring, I noticed that there was a small discrepancy: we state that the type checker differentiates between terms and formulae when that is not the case anymore. Additionally, there were some outdated node packages which led to security problems. I figured that these two issues were relevant enough that they warranted a small PR to fix them. I also changed the git hub actions to use an updated version of node.