Add monadic interface to solver #52
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to plug in concurrency monads like Lwt, Async or Dune's Fiber into the solver and have the callbacks return the concurrency monad.
|
This isn't needed with OCaml 5 - in fact, the ICFP Eio tutorial used the example of performing Lwt operations in the solver's callback, without having to modify the solver at all. It seems a shame to add all this just for older systems. Dune has a way to build on newer compilers but run with older ones - perhaps that could be used instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to plug in concurrency monads like Lwt, Async or Dune's Fiber into the solver and have the callbacks return the concurrency monad.
Currently work in progress, needs support code in 0install-solver as well.