Add type constraint to binding_op #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpetiot
added
the
no changelog
Julow
reviewed
Dec 7, 2023
lib/Ast.ml
Outdated
| @@ -1893,14 +1905,14 @@ end = struct | |||
| | Fp {pparam_desc= Pparam_val (_, _, _); _}, Ppat_cons _ -> true | |||
| | Pat {ppat_desc= Ppat_construct _; _}, Ppat_cons _ -> true | |||
| | _, Ppat_constraint (_, {ptyp_desc= Ptyp_poly _; _}) -> false | |||
| | ( Exp {pexp_desc= Pexp_letop _; _} | |||
| | ( (Exp {pexp_desc= Pexp_letop _; _} | Bo {pbop_typ= Some _; _}) | |||
There was a problem hiding this comment.
Parenthesing of pattern is not consistent, maybe some AST rules are missing ?
let _ =
let (_ as foo) = foo in
let+ _ as foo = foo in
()These parentheses are intended for disambiguation, I think.
gpetiot
force-pushed
the
binding-op-constraint
branch
from
e8769df to
5ecdbf3
Compare
|
I think I fixed all regressions, test_branch doesn't report any diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to #2401
The main positive is removing
Sugar.type_cstr(all this code is inconvenient for the polynewtypes shenanigans) by doing this work in the parser.A minor side effect is that we don't add useless parentheses around:
let* ({ state; server; pool } as t) = xxxlet+ (Ok x) = xxxIt's a fix, but not important enough to add a line in the changelog.