Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parenthesis after try..with #2537

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Julow
Copy link
Collaborator

@Julow Julow commented Apr 11, 2024

Fix commit #2536 (comment)

When indicate-multiline-delimiters=closing-on-separate-line, the closing parenthesis at the end of a try..with expression is missing since #2528.

When indicate-multiline-delimiters=closing-on-separate-line, the closing
parenthesis at the end of a try..with expression is missing since ocaml-ppx#2528.
@Julow Julow added the no changelog set this to bypass the CI check for changelog entries label Apr 11, 2024
@nojb
Copy link
Contributor

nojb commented Apr 12, 2024

I confirm this fixes #2536 (comment). Thanks!

@Julow
Copy link
Collaborator Author

Julow commented Apr 12, 2024

Thanks for checking! Let's merge.

@Julow Julow merged commit 54fff68 into ocaml-ppx:main Apr 12, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog set this to bypass the CI check for changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants