nest-match=align now works with match%ext. #2648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does the linux build fail because of lacking sudo priviledges ? I had hoped to see the result of test-branch. |
Julow
reviewed
Feb 3, 2025
| ({pexp_desc= Pexp_match _ | Pexp_try _; pexp_loc; _}, _) | ||
| } ] ) | ||
| , `Align ) | ||
| when Source.extension_using_sugar ~name:ext ~payload:pexp_loc -> |
There was a problem hiding this comment.
This function is used quite often, at some point we could consider putting this information in the Pexp_extension node.
There was a problem hiding this comment.
Yes of course, but that turns a simple patch into a complicated project. I don't think my employer would be willing to let me do it.
There was a problem hiding this comment.
I'm mentioning this in case it spawns ideas. Of course, I want this fix to go in first.
EmileTrotignon
force-pushed
the
match-align-ext-sugar
branch
from
6368226 to
b901525
Compare
|
I think this is good to go |
Julow
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match%ext used to not be treated the same by nest-match-align. This is now fixed.
Requested in Issue #2081
Seems to be a very lightweight patch, and that the bug was not present at all in the test base.