5.3 AST bump #558
Open
5.3 AST bump #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current, internal AST is 4.14. With this change it is now 5.2. The most notable changes are the representation of functions and locally opening modules for type definitions. Signed-off-by: Patrick Ferris <[email protected]>
Signed-off-by: Patrick Ferris <[email protected]>
There are only two significant changes to the AST from 5.2 to 5.3: the addition of a dedicated effects AST node and constant nodes getting a location. The latter will likely be the most impacting change to downstream dependencies of ppxlib. Signed-off-by: Patrick Ferris <[email protected]>
patricoferris
requested review from
ceastlund,
NathanReb,
panglesd and
pitag-ha
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is building off of #514 -- a much more manageable AST change. There are only two significant changes to the AST from 5.2 to 5.3: the addition of a dedicated effects AST node and constant nodes getting a location. The latter will likely be the most impacting change to downstream dependencies of ppxlib.
Of course, we need to get #514 in first, but this is ready for when we want to make the next change and catch up with ocaml/ocaml, from there we should be able to have a more regular AST bump cadence (depending on how the parsetree changes).