Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update missing copyrights #908

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update missing copyrights #908

wants to merge 2 commits into from

Conversation

let-def
Copy link
Contributor

@let-def let-def commented Jan 29, 2019

Copyright line is now " Copyright (C) 2013 - 2019 Merlin contributors".

IANAL, I have no idea what I am doing.

@let-def
Copy link
Contributor Author

let-def commented Jan 29, 2019

@avsm: Flow copyright is copied there (with the path to MIT LICENSE updated) https://github.com/ocaml/merlin/pull/908/files#diff-1ead05ed940a205c93fcfead82ab8caeR36

trefis
trefis reviewed Jan 29, 2019
View reviewed changes
src/analysis/expansion.ml

This file is part of Merlin, an helper for ocaml editors

Copyright (C) 2013 - 2019 Merlin contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Merlin contributors"

Not sure what value that holds...

@avsm
Copy link
Member

avsm commented Feb 22, 2019

(IANAL also) My understanding of the Merlin repository is that the original MIT license was added to the repository 6 years ago. Since then, the common understanding is that any contributions sent here via PRs would be covered by that license as well. Therefore, you can define the Merlin contributors somewhere in the repository as the assemblage of those GitHub ids. So the PR here seems fine to me, with some clarification perhaps being helpful about who those contributors are so there is no ambiguity.

@XVilka
Copy link

XVilka commented Nov 29, 2019

Should be this one reconsidered too? Would be a nice addition for the next release (with 4.09 support) if accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trefis trefis trefis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@let-def @avsm @XVilka @trefis