Make in keyword completion less aggressive

ocaml · Aug 23, 2024 · 211b094 · 211b094
1 parent c894916
commit 211b094
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 24 deletions.
diff --git a/ocaml-lsp-server/src/compl.ml b/ocaml-lsp-server/src/compl.ml
@@ -175,7 +175,7 @@ module Complete_by_prefix = struct
 
   let complete_keywords completion_position prefix =
     match prefix with
-    | "" | "i" | "in" ->
+    | "i" | "in" ->
       let ci_for_in =
         CompletionItem.create
           ~label:"in"

diff --git a/ocaml-lsp-server/test/e2e-new/completion.ml b/ocaml-lsp-server/test/e2e-new/completion.ml
@@ -1100,21 +1100,10 @@ let%expect_test "completion for `in` keyword - no prefix" =
 let foo param1 =
   let bar = param1 |ocaml} in
   let position = Position.create ~line:2 ~character:19 in
-  print_completions ~limit:3 source position;
+  print_completions ~limit:2 source position;
   [%expect
     {|
     Completions:
-    {
-      "kind": 14,
-      "label": "in",
-      "textEdit": {
-        "newText": "in",
-        "range": {
-          "end": { "character": 19, "line": 2 },
-          "start": { "character": 19, "line": 2 }
-        }
-      }
-    }
     {
       "detail": "'a -> 'b",
       "kind": 12,
@@ -1252,17 +1241,6 @@ let%expect_test "completion for object methods" =
   [%expect
     {|
     Completions:
-    {
-      "kind": 14,
-      "label": "in",
-      "textEdit": {
-        "newText": "in",
-        "range": {
-          "end": { "character": 34, "line": 0 },
-          "start": { "character": 34, "line": 0 }
-        }
-      }
-    }
     {
       "detail": "'a",
       "kind": 2,