fix: close stderr in [run_in_directory]

Otherwise we're going to leak a file descriptor Signed-off-by: Rudi Grinberg <[email protected]>
ocaml · Jul 28, 2024 · 2d2610c · 2d2610c
1 parent a129457
commit 2d2610c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,10 +1,12 @@
-# Unreelased
+# Unreleased
 
 ## Fixes
 
 - Kill unnecessary ocamlformat processes with sigterm rather than sigint or
   sigkill (#1343)
 
+- Fix fd leak in running external processes for preprocessing (#1349)
+
 # 1.18.0
 
 ## Features

diff --git a/ocaml-lsp-server/src/ocaml_lsp_server.ml b/ocaml-lsp-server/src/ocaml_lsp_server.ml
@@ -929,6 +929,7 @@ let run_in_directory ~prog ~prog_is_quoted:_ ~args ~cwd ?stdin ?stdout ?stderr (
   in
   Unix.close stdin;
   if should_close_stdout then Unix.close stdout;
+  Option.iter stderr ~f:Unix.close;
   `Finished res
 ;;