Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(lsp): add missing client to server requests #1340

Merged

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Jul 11, 2024

  • inlayHint/resolve
  • textDocument/inlineValue
  • textDocument/diagnostic
  • textDocument/inlineCompletion
  • workspace/diagnostic
  • workspaceSymbol/resolve
  • textDocument/rangesFormatting
  • textDocument/prepareTypeHierarchy
  • typeHierarchy/subtype
  • typeHierarchy/supertypes

@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 4433

Details

  • 0 of 135 (0.0%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 21.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/ocaml_lsp_server.ml 0 14 0.0%
lsp/src/client_notification.ml 0 24 0.0%
lsp/src/client_request.ml 0 97 0.0%
Files with Coverage Reduction New Missed Lines %
lsp/src/client_request.ml 1 15.49%
lsp/src/client_notification.ml 2 18.97%
Totals Coverage Status
Change from base Build 4428: -0.1%
Covered Lines: 5526
Relevant Lines: 25410

💛 - Coveralls

@rgrinberg rgrinberg force-pushed the ps/rr/feature_lsp___add_missing_client_to_server_requests branch 3 times, most recently from e77b5b8 to 60a6528 Compare July 12, 2024 22:42
- inlayHint/resolve
- textDocument/inlineValue
- textDocument/diagnostic
- textDocument/inlineCompletion
- workspace/diagnostic
- workspaceSymbol/resolve
- textDocument/rangesFormatting
- textDocument/prepareTypeHierarchy
- typeHierarchy/subtype
- typeHierarchy/supertypes

- notebookDocument/didChange
- notebookDocument/didClose
- notebookDocument/didOpen
- notebookDocument/didSave

Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: dd44f210-749e-4518-8b4e-9e9f4613b4d2 -->
@rgrinberg rgrinberg force-pushed the ps/rr/feature_lsp___add_missing_client_to_server_requests branch from 60a6528 to 3fed413 Compare July 12, 2024 23:16
@rgrinberg rgrinberg merged commit 0c7be13 into master Jul 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants