-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct custom query #1348
Construct custom query #1348
Conversation
55b75ea
to
63e7c91
Compare
Pull Request Test Coverage Report for Build 4531Details
💛 - Coveralls |
When you say "can be useful", do you mean you have a concrete user in mind? Perhaps a client where you are planning to use this. |
Using Lsp through Emacs (that does not rely to much on hover and interactivy on top of mouse) can make the usage of |
I don't doubt the potential. What I'm saying is that until some client actually demonstrates real intention in using your custom request, you're just adding dead code. In the lsp standard itself, there's a requirement to demonstrate at least one client implementation for every additional protocol extension. We don't have to go that far, but how about we at least get some feedback from at least one actual client developer that is going to use this custom request before jump the gun. |
@rgrinberg
|
Okay, so what I'm getting is that the only client developer we need to consider is from JS. So let's have somebody from there have a look at this request to do a sanity check. |
63e7c91
to
26ad6ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just need a few tweaks to the documentation.
26ad6ec
to
b2939c2
Compare
b2939c2
to
b98322f
Compare
At the moment, construct is a completion hook, and in some cases accessing it via a one-off query can be useful.