Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close stderr in [run_in_directory] #1349

Merged
merged 2 commits into from
Aug 3, 2024
Merged

fix: close stderr in [run_in_directory] #1349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d2610c
fix: close stderr in [run_in_directory]
rgrinberg Jul 21, 2024
09f4a29
Merge branch 'master' into ps/rr/fix__close_stderr_in__run_in_directory_
voodoos Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
# Unreelased
# Unreleased

## Fixes

- Kill unnecessary ocamlformat processes with sigterm rather than sigint or
sigkill (#1343)

- Fix fd leak in running external processes for preprocessing (#1349)

# 1.18.0

## Features
Expand Down
1 change: 1 addition & 0 deletions ocaml-lsp-server/src/ocaml_lsp_server.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,7 @@ let run_in_directory ~prog ~prog_is_quoted:_ ~args ~cwd ?stdin ?stdout ?stderr (
in
Unix.close stdin;
if should_close_stdout then Unix.close stdout;
Option.iter stderr ~f:Unix.close;
voodoos marked this conversation as resolved.
Show resolved Hide resolved
`Finished res
;;

Expand Down
Loading