Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump Custom Requests #1361

Closed
wants to merge 3 commits into from
Closed

Jump Custom Requests #1361

wants to merge 3 commits into from

Conversation

PizieDust
Copy link
Contributor

@PizieDust PizieDust commented Aug 22, 2024 •
edited
Loading

closes #1360
This PR contains an implementation for a custom requests based on Merlin's jump command.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4486

Details

  • 22 of 29 (75.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 21.833%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/custom_requests/req_jump.ml 22 29 75.86%
Totals Coverage Status
Change from base Build 4483: 0.07%
Covered Lines: 5550
Relevant Lines: 25420
💛 - Coveralls

@rgrinberg
Copy link
Member

Thanks. @awilliambauer could you read the spec if you have some time? Do you plan to do anything with this custom request?

@PizieDust PizieDust closed this Aug 28, 2024
@PizieDust
Copy link
Contributor Author

Using CodeActions has made this PR obsolete. See #1364

@PizieDust PizieDust mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntactic and Semantic movement shortcuts
3 participants
@PizieDust @coveralls @rgrinberg