Add a new option to mute the hover response. #1416
Merged
+178
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know it is not possible to disable the default hover provider on the client side in vscode due to how the official LSP client implementation manage it.
However it is sometimes necessary to disable that hover provider to provide alternative information in the hover tooltips without additional clutter.
This PR introduces an option that allows the client to ask the server to not return anything when hover requests are made.
The diff is a bit larger than necessary because
dune build @lint
had not been run when options when last updated so the inlining has changed a bit.The first use case for this option is described in this vscode-ocaml-platform PR: ocamllabs/vscode-ocaml-platform#1675