Driver voodoo mode: generation of a status.json with a list of redirections
#1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panglesd
changed the title
sttaus.json with a list of redirectionsstatus.json with a list of redirections
panglesd
added
the
no changelog
jonludlam
reviewed
Feb 12, 2025
src/driver/bin/odoc_driver_voodoo.ml
Outdated
| in | ||
| let redirections = `List redirections in | ||
| `Assoc | ||
| [ ("files", files); ("failed", failed); ("redirections", redirections) ] |
There was a problem hiding this comment.
If we're creating this file here now we'll have to correctly put in the 'files' field
There was a problem hiding this comment.
Right. And I guess the "failed" field?
There was a problem hiding this comment.
The idea is that we report the solver failure / build failure if there's been a problem. If we're executing this code, we've by definition not failed :-)
|
This PR adds the status.json file also to the normal mode, with some fields from #1134 (comment) (package name and version) |
|
Nice, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows in ocaml.org to redirect the old links (
p/<pkgname>/<version>/<modulename>/) to the new ones (p/<pkgname>/<version>/<libraryname>/<modulename>/).To be combined with this (WIP) branch.