Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] dns, dns-stub, dns-certify, dns-mirage, dns-resolver, dns-client, dns-server, dns-tsig and dns-cli (5.0.0) #18504

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Apr 14, 2021

An opinionated Domain Name System (DNS) library

CHANGES:

…ns-client, dns-server, dns-tsig and dns-cli (5.0.0)

CHANGES:

* IPv6 support for client and server (Mirage, Unix, Lwt) (mirage/ocaml-dns#249 mirage/ocaml-dns#252 @hannesm)
  This results in breaking changes, especially in the Mirage boilerplate,
  since now a Mirage_stack.V4V6 is needed instead of a Mirage_stack.V4.
* dns-certify: support EC private keys, now that X509 0.12.0 supports them
  (mirage/ocaml-dns#252 @hannesm)
@hannesm
Copy link
Member Author

hannesm commented Apr 14, 2021

//cc @dinosaure

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Apr 14, 2021

The failures on OCaml 4.13 are due to a bug in the type-checker: ocaml/ocaml#10271 so it can be ignored

@hannesm
Copy link
Member Author

hannesm commented Apr 14, 2021

failures:

@camelus
Copy link
Contributor

camelus commented Apr 14, 2021

Commit: 9470681

A pull request by opam-seasoned @hannesm.

☀️ All lint checks passed 9470681
  • These packages passed lint tests: capnp-rpc-mirage.0.7.0, capnp-rpc-mirage.0.8.0, capnp-rpc-mirage.0.9.0, capnp-rpc-mirage.1.0, conduit-mirage.2.2.1, conduit-mirage.2.3.0, conduit-mirage.3.0.0, dkim.0.1.0, dns-certify.5.0.0, dns-cli.5.0.0, dns-client.5.0.0, dns-mirage.5.0.0, dns-resolver.5.0.0, dns-server.5.0.0, dns-stub.5.0.0, dns-tsig.5.0.0, dns.5.0.0, git-mirage.3.0.0, git-mirage.3.1.0, git-mirage.3.1.1, git-mirage.3.2.0, git-mirage.3.3.0, git-mirage.3.3.1, git-mirage.3.3.2, git-mirage.3.3.3, resp-mirage.0.10.0

☀️ Installability check (+9)
  • new installable packages (9): dns.5.0.0 dns-certify.5.0.0 dns-cli.5.0.0 dns-client.5.0.0 dns-mirage.5.0.0 dns-resolver.5.0.0 dns-server.5.0.0 dns-stub.5.0.0 dns-tsig.5.0.0

@hannesm
Copy link
Member Author

hannesm commented Apr 15, 2021

I looked through the CI failures, and they are unrelated. This is good to be merged.

@talex5
Copy link
Contributor

talex5 commented Apr 15, 2021

Note sure why the builds on pima were failing. I restarted a few and they seemed fine the second time.

@hannesm
Copy link
Member Author

hannesm commented Apr 15, 2021

Thanks @talex5. I pushed a commit to restrict "resp-mirage" to conduit-mirage <2.3.0 to fix a CI issue that @kit-ty-kate was curious about.

@hannesm
Copy link
Member Author

hannesm commented Apr 15, 2021

looks like resp-mirage 0.10.0 is still in a non-working state. I doubt the root cause is a release of dns, and don't have the motivation to investigate further.

what can I do to get this PR merged?

@hannesm
Copy link
Member Author

hannesm commented Apr 15, 2021

I force-pushed a fix for resp-mirage -- it requires conduit-mirage 2.3.0 or later (not below, and not above 2.0.0). now CI has various other temporary issues.

@mseri
Copy link
Member

mseri commented Apr 15, 2021

Looks fine, the remaining jobs are all timing out (which is not surprising imho given the amount of things this PR is testing). I think this can be merged

@mseri mseri mentioned this pull request Apr 15, 2021
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 2f35593 into ocaml:master Apr 16, 2021
@hannesm
Copy link
Member Author

hannesm commented Apr 16, 2021

thanks!

@hannesm hannesm deleted the release-dns-5.0.0 branch April 16, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants