Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [new release] js_of_ocaml (8 packages) (6.0.0) #27361

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Feb 3, 2025

Compiler from OCaml bytecode to JavaScript

CHANGES:

Features/Changes

Bug fixes

CHANGES:

## Features/Changes
* Compiler/Runtime: Make resuming a continuation more efficient in js (ocsigen/js_of_ocaml#1765)
* Compiler/Runtime: Effects: add an optional feature of "dynamic switching" between CPS
  and direct style, resulting in better performance when
  no effect handler is installed
* Compiler: Merged Wasm_of_ocaml (ocsigen/js_of_ocaml#1724)
* Lib: fix the type of some DOM properties and methods (ocsigen/js_of_ocaml#1747)
* Lib: removed no longer relevant Js.optdef type annotations (ocsigen/js_of_ocaml#1769)
* Lib: Add other textMetrics property (ocsigen/js_of_ocaml#1784)
* Lib: rename Firebug to Console (ocsigen/js_of_ocaml#1802)
* Test: use dune test stanzas (ocsigen/js_of_ocaml#1631)
* Test: run wasm tests on windows
* Misc: drop support for IE
* Misc: move tests to OCaml 5.3
* Misc: import many test from the OCaml codebase
* Runtime: support for float16 bigarrays
* Runtime: support more Unix functions (ocsigen/js_of_ocaml#1823)
* Runtime: various filesystem fixes (ocsigen/js_of_ocaml#1825)

## Bug fixes
* Compiler: Fix small bug in global data flow analysis (ocsigen/js_of_ocaml#1768)
* Runtime: no longer leak channels
* Runtime: Fix Marshal.to_buffer (ocsigen/js_of_ocaml#1798)
* Runtime: unmarshalling objects should refresh its id
* Runtime: check size upper bound during array creation
* Runtime: return sys_error when reading from a closed channels
* Runtime: fix parsing of hex-float with very large exponent
* Runtime: make sure [n / 0L] is not optimized away by DCE
* Runtime: fix Unix.LargeFile.stat/lstat
* Runtime: fix stat/lstat times
* Runtime: fix reading from stdin in an interactive nodejs
@hhugo
Copy link
Contributor Author

hhugo commented Feb 4, 2025

cc @vouillon @OlivierNicole

@hhugo hhugo changed the title [new release] js_of_ocaml (8 packages) (6.0.0) [WIP] [new release] js_of_ocaml (8 packages) (6.0.0) Feb 4, 2025
@hhugo hhugo marked this pull request as draft February 4, 2025 09:30
@hhugo
Copy link
Contributor Author

hhugo commented Feb 4, 2025

@vouillon, I wonder if the CI is having the same issue I had with binaryen on windows in ocsigen/js_of_ocaml#1797 (comment)

@vouillon
Copy link
Member

vouillon commented Feb 4, 2025

It seems that the errors means that either wasm-merge.exe or one of the dynamic libraries it depends on is not found.

@hhugo
Copy link
Contributor Author

hhugo commented Feb 4, 2025

It seems that the errors means that either wasm-merge.exe or one of the dynamic libraries it depends on is not found.

I can retry locally at some point later.

@hhugo
Copy link
Contributor Author

hhugo commented Feb 5, 2025

It seems that the errors means that either wasm-merge.exe or one of the dynamic libraries it depends on is not found.

Trying to debug this a bit in VS, I get libgcc_s_seh-1.dll not found..

@vouillon
Copy link
Member

vouillon commented Feb 5, 2025

It seems that the errors means that either wasm-merge.exe or one of the dynamic libraries it depends on is not found.

Trying to debug this a bit in VS, I get libgcc_s_seh-1.dll not found..

Shouldn't this library come with conf-mingw-w64-g++-x86_64?

@hhugo
Copy link
Contributor Author

hhugo commented Feb 5, 2025

It seems that the errors means that either wasm-merge.exe or one of the dynamic libraries it depends on is not found.

Trying to debug this a bit in VS, I get libgcc_s_seh-1.dll not found..

Shouldn't this library come with conf-mingw-w64-g++-x86_64?

I don't know, I don't have such issue with the official windows binary release, maybe they don't use cygwin. @dra27, any idea ? Do we need additional setup ?

@vouillon
Copy link
Member

vouillon commented Feb 5, 2025

They use Visual Studio. But I don't think we can expect all OCaml Windows users to have Visual Studio installed.

Oh, I meant conf-mingw-w64-gcc-x86_64 above. We install conf-mingw-w64-g++-x86_64 (which depends on it) to build wasm-merge.exe I can see the library in the Cygwin package file list: https://cygwin.com/packages/x86_64/mingw64-x86_64-gcc-core/mingw64-x86_64-gcc-core-12.4.0-1. Do you have mingw64-x86_64-gcc-core installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants