New package charrua-core, a DHCP/SERVER library. #4938
Conversation
|
woohoo! |
|
whoot whooot \o/ |
✅ All lint checks passed af2cc3e
✅ Installability check (4047 → 4048)
|
| @@ -0,0 +1,36 @@ | |||
| ### Charrua DHCP core library. | |||
There was a problem hiding this comment.
Can you remove the ###? opam list will show them, which is a bit ugly :p
There was a problem hiding this comment.
Done !
On 9 October 2015 at 12:26, Thomas Gazagnaire [email protected]
wrote:
In packages/charrua-core/charrua-core.0.1/descr
#4938 (comment):@@ -0,0 +1,36 @@
+### Charrua DHCP core library.Can you remove the ### opam list will show them, which is a bit ugly :p
—
Reply to this email directly or view it on GitHub
https://github.com/ocaml/opam-repository/pull/4938/files#r41616808.
|
desc is fixed, ### removed, nothing to add so far from me. |
|
Could someone pull this in ? I have more stuff in the pipeline that depends on this. |
New package charrua-core, a DHCP/SERVER library.
|
thanks \o/ |
| build: [ | ||
| ["sh" "build.sh"] | ||
| ] | ||
| depends: [ |
There was a problem hiding this comment.
do you use the syntax extensions of anything? That would also need camlp4 (but it built, so just checking in)
There was a problem hiding this comment.
Hmm well spot, I use the extensions for Lwt, should I add a camlp4 for 0.2 ?
There was a problem hiding this comment.
Here are also a few comments about your build procedure:
- You are relying on a static
.installfile for installation. This will break for example in switches where only the byte-code compilers are available. Also you don't have support for native dynamic linking (.cmxsfiles) in there. - You are using a shell script which is Windows unfriendly.
You can use topkg to solve these problems, it shouldn't change anything to your current setup, except add a new file and change your package build procedure.
There was a problem hiding this comment.
Cool, I'll use it on v0.2, created an issue: mirage/charrua#16
There was a problem hiding this comment.
I'm about to submit a package that will suffer the same issues, but next version it should be fixed. Thanks for the pointers, I struggled a bit with the build system.
No description provided.