Skip to content

Commit

Permalink
Revert "Minimal support for web (#962)"
Browse files Browse the repository at this point in the history
This reverts commit 536b529.
  • Loading branch information
ulugbekna authored and rgrinberg committed Jul 2, 2022
1 parent 21d8367 commit bb7ba62
Show file tree
Hide file tree
Showing 9 changed files with 63 additions and 140 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ node_modules/
# VSCode build artifacts
dist/
.vscode-test/
.vscode-test-web/
*.vsix

# DS_Store
Expand Down
1 change: 0 additions & 1 deletion .ocamlformat-ignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
node_modules/
.vscode-test/
.vscode-test-web/
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ test/fixtures/sample-esy/esy.lock/
# Normal npm stuff
node_modules/
.vscode-test/
.vscode-test-web/
dist/
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
- Upgrade to `vscode-languageclient` v8.0.1. This may fix some stability
problems

- Revert "Add minimal support as a Web Extension (#962)" because of regressions

## 1.10.6

- Update known ocamllsp versions (#972)
Expand Down
27 changes: 0 additions & 27 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ switch: create_switch deps ## Create an opam switch and install development depe
.PHONY: build
build: ## Build the project
dune build src/vscode_ocaml_platform.bc.js
dune build src-browser/vscode_ocaml_platform_web.bc.js
yarn --cwd astexplorer start
yarn esbuild _build/default/src/vscode_ocaml_platform.bc.js \
--bundle \
Expand All @@ -30,22 +29,10 @@ build: ## Build the project
--platform=node \
--target=es6 \
--sourcemap
yarn esbuild _build/default/src-browser/vscode_ocaml_platform_web.bc.js \
--bundle \
--external:vscode \
--external:fs \
--external:tty \
--external:child_process \
--external:constants \
--outdir=dist \
--platform=browser \
--target=es6 \
--sourcemap

.PHONY: build-release
build-release:
dune build src/vscode_ocaml_platform.bc.js --profile=release
dune build src-browser/vscode_ocaml_platform_web.bc.js --profile=release
yarn --cwd astexplorer build
yarn esbuild _build/default/src/vscode_ocaml_platform.bc.js \
--bundle \
Expand All @@ -57,20 +44,6 @@ build-release:
--minify-syntax \
--sourcemap \
--sources-content=false
yarn esbuild _build/default/src-browser/vscode_ocaml_platform_web.bc.js \
--bundle \
--external:vscode \
--external:fs \
--external:tty \
--external:child_process \
--external:constants \
--outdir=dist \
--platform=browser \
--target=es6 \
--minify-whitespace \
--minify-syntax \
--sourcemap \
--sources-content=false

.PHONY: test
test: ## Run the unit tests
Expand Down
Loading

0 comments on commit bb7ba62

Please sign in to comment.