Map Alt+D to the correct action kind in package.json #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@voodoos I think this should be fixed on the LSP side, what do you think? |
I don't think so, the action was renamed and split into two in ocaml/ocaml-lsp#1283 |
voodoos
approved these changes
Mar 13, 2025
|
Oh, I didn't know it was renamed. Let's add a change log entry and go ahead! |
Signed-off-by: Sora Morimoto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension assigns the key binding Alt+D to the very useful "destruct" code action, but currently the key binding doesn't do anything (also see ocaml/ocaml-lsp#1301).
I did some digging and discovered that the definition of the key binding is passing the
destructkind, but ocaml-lsp actually names the kinddestruct (enumerate cases).Now the keybinding is correctly mapped to the destruct action, and I also see the keys suggested in the code actions context menu:
