Skip to content

fix: preserve table options when adding sparse vector indexes #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xxsc0529 merged 1 commit into from
Feb 5, 2026
Merged

fix: preserve table options when adding sparse vector indexes #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pyobvector/client/ob_vec_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,20 @@ def create_table_with_index_params(
)
if sparse_vidxs is not None and len(sparse_vidxs) > 0:
create_table_sql = str(CreateTable(table).compile(self.engine))
new_sql = create_table_sql[: create_table_sql.rfind(")")]
# Preserve table options (e.g. ORGANIZATION=heap) after the closing ")"
last_paren = create_table_sql.rfind(")")
table_options_suffix = create_table_sql[
last_paren:
] # e.g. ")ORGANIZATION=heap"
new_sql = create_table_sql[:last_paren]
for sparse_vidx in sparse_vidxs:
sparse_params = sparse_vidx._parse_kwargs()
if "type" in sparse_params:
new_sql += f",\n\tVECTOR INDEX {sparse_vidx.index_name}({sparse_vidx.field_name}) with (type={sparse_params['type']}, distance=inner_product)"
else:
new_sql += f",\n\tVECTOR INDEX {sparse_vidx.index_name}({sparse_vidx.field_name}) with (distance=inner_product)"
new_sql += "\n)"
# Restore table options after the new closing ")"
new_sql += "\n)" + table_options_suffix[1:]
conn.execute(text(new_sql))
else:
table.create(self.engine, checkfirst=True)
Expand Down