New features #86
Merged
New features #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Having all the features already working is a huge help. 👍 |
|
I am going to rebase and merge this PR first. The other PR changes too much things around conversations and I need more time to ensure that everything works fine and there are no problems migrating. |
- Use `messagesUri.threads` instead of passing empty threadId to `messagesUri.thread`. - Check for existence of location header and conversation id.
|
I just finished reviewing your changes: it's pretty good. I just did a small update in |
demurgos
added a commit
to demurgos/skype-http
that referenced
this pull request
Feb 14, 2018
Also adds changelog entries for ocilo#86. - Closes ocilo/skype-http385
Merged
demurgos
added a commit
to demurgos/skype-http
that referenced
this pull request
Feb 14, 2018
Also adds changelog entries for ocilo#86. - Closes ocilo/skype-http385
demurgos
added a commit
to demurgos/skype-http
that referenced
this pull request
Feb 14, 2018
Also adds changelog entries for ocilo#86. - Closes ocilo/skype-http385
demurgos
added a commit
to demurgos/skype-http
that referenced
this pull request
Feb 14, 2018
Also adds changelog entries for ocilo#86. - Closes ocilo/skype-http385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I use this methods in my matrix-skype project and it would be great if you add it to your project. I have never used typescript before, probably there are some incorrect interafaces or types.