Add toggle and beforetoggle events for the popover API.
#806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2024
SylvainBoilard
force-pushed
the
master
branch
from
bcb952e to
636b17b
Compare
SylvainBoilard
force-pushed
the
master
branch
from
636b17b to
da2540f
Compare
SylvainBoilard
changed the title
toggle event for details elements.toggle and beforetoggle events for the popover API.
SylvainBoilard
force-pushed
the
master
branch
from
7d257fc to
2797b6e
Compare
…r` API. This also adds support for the `toggle` event for `details` elements. See: - https://html.spec.whatwg.org/multipage/popover.html ; - https://html.spec.whatwg.org/multipage/indices.html#event-toggle ; - https://html.spec.whatwg.org/multipage/interactive-elements.html#the-details-element ; - https://developer.mozilla.org/en-US/docs/Web/API/Popover_API ; - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#events ; - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#attributes .
|
Thank you for your PR. I'm still waiting for the support in js_of_ocaml to be merged to merge everything in one go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR initially added support for
toggleevent handlers indetailselements and was extended to support bothtoggleandbeforetoggleevents for thepopoverAPI.See:
See also these related PRs:
Please let me know of any issues.
Cheers,