Merge wasm_of_ocaml #1724
Merge wasm_of_ocaml #1724
Conversation
Revert test_fun_call and test_poly_compare and don't run them in Wasm. Add additional tests test_fun_call2 and test_poly_equal that make sense in Wasm.
This does not make any difference with binaryen which conflated both, but the spec mandates the former.
dune-build-info use a 64-byte placeholder. This ensures that such strings are encoded as a sequence of bytes in the wasm module.
Add copyright headers
Switch to Binaryen 118
This reverts commit 25315fb4d3231ecd0fdc07c57adec59f3e697dc3. No longer useful with WebAssembly/binaryen#6507
Effects: make continuation format compatible with OCaml 5.2
This stops a few tests from failing with Wasm
Add type Js.number_t
Lib: use number_t in Typed_array as well
Lib: use number_t in yet a few more places
Fix typo in `caml_ba_get_3` bounds check
Fix implementation of caml_register_named_value
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
| export PATH=$(echo $PATH | cut -d : -f 2-) # Do not call oneself recursively | |||
There was a problem hiding this comment.
This is a bit fragile. There could be other directories added by dune. I'll commit an alternative.
Source maps: clean-up
The wasm_of_ocaml runtime will be under runtime/wasm.
See: - https://html.spec.whatwg.org/multipage/interactive-elements.html#the-details-element ; - https://html.spec.whatwg.org/multipage/indices.html#event-toggle ; - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#attributes ; - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details#events .
This reverts commit f428e0e.
| in | ||
| let no_sourcemap = | ||
| let doc = | ||
| "Don't generate source map. All other source map related flags will be be ignored." |
There was a problem hiding this comment.
| "Don't generate source map. All other source map related flags will be be ignored." | |
| "Don't generate source map. All other source map related flags will be ignored." |
At Tarides we have no intention of letting it bitrot. In the foreseeable future I expect Jérôme to be the main maintainer, with me possibly doing small work here and there.
Ideally, big packages that haven’t yet done a release with explicit float conversions should do so first, before wasm_of_ocaml is released. This is because after the release, the type
The intention is for this repo to become the development repo, yes. |
|
I think it's going to be much simpler to use this repo as the main development repo and to release wasm_of_ocaml at the same time as other jsoo packages, given how tightly it depends on the js_of_ocaml compiler library. |
I don't really understand why we would need to wait here ? Isn't it better to have wasmoo out first so that other packages can add support for their next releases. It would be better to get the correct constraint in the opam-repository anyway. I want to release the current-ish state of master soon (with limited breakage). And then a major release with wasmoo. People not able to upgrade to the latest version of jsoo won't miss much features/changes in that case. |
|
I suppose this works, if all these packages have upper bounds on their version of js_of_ocaml. |
|
One thing that would help A LOT would be identify all packages broken by this PR and add an upper bound on the js_of_ocaml version ( |
This aims to merge wasm_of_ocaml, currently hosted at https://github.com/ocaml-wasm/wasm_of_ocaml, back into this repo.
This is pending on Dune support ocaml/dune#11029. For now, Dune is pinned for the CI jobs.