Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check wasmoo js runtime #1909

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Check wasmoo js runtime #1909

merged 2 commits into from
Apr 8, 2025

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Mar 30, 2025

No description provided.

@hhugo hhugo requested a review from vouillon March 30, 2025 12:22
@vouillon
Copy link
Member

I was planning on adding more structure on the file generated by gen.ml, not less, to support multiple precompiled runtimes:
0358924#diff-a343086c1e25da51180175ccb77f6c7726317f75db5e020e56f4b6061f7b5ac3
I'm not sure how your changes fit.

@hhugo hhugo force-pushed the check-runtime-wasm branch from ca50ecf to ad510a0 Compare April 8, 2025 13:53
@hhugo
Copy link
Member Author

hhugo commented Apr 8, 2025

I've rebased the PR. Are you happy with it ?

@hhugo
Copy link
Member Author

hhugo commented Apr 8, 2025

@vouillon ^^

@hhugo hhugo merged commit 3d71bec into master Apr 8, 2025
25 of 26 checks passed
@hhugo hhugo deleted the check-runtime-wasm branch April 8, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants