add stub for unix_isatty #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, can you add an entry to the changelog (CHANGES.md) ? |
Done |
|
thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #913 and reasonml/reason-native#207
I tested this by running some JS tests compiled with Rely normally in a terminal and by piping the output to
catwhich should not be a tty. I also console logged the result of calling Unix.isatty on Unix.stdin to verify the function was returning the correct values. I thought I would need to provide values for Unix.stdin etc, but it was not necessary. I verified that the unix.isatty returns false and does not error in chrome as well.I couldn't figure out the test structure of this repo and this change is fairly simple, so I did not add any automated tests, but could do so if desired with some help.