Skip to content

Commit

Permalink
template.distillery: add lwt_log to package list
Browse files Browse the repository at this point in the history
  • Loading branch information
Jan Rochel committed Dec 26, 2018
1 parent 00ec8f4 commit d752ef3
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions template.distillery/Makefile.options
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ CLIENT_FILES := $(wildcard *.eliomi *.eliom) \
SERVER_ELIOM_PACKAGES := ocsigen-start.server

# OCamlfind packages for the server
SERVER_PACKAGES := lwt_ppx js_of_ocaml-ppx.deriving ppx_deriving.std
SERVER_PACKAGES := lwt_log lwt_ppx js_of_ocaml-ppx.deriving ppx_deriving.std

# OCamlfind packages for database access
SERVER_DB_PACKAGES := pgocaml.syntax

# OCamlfind packages for the client
CLIENT_PACKAGES := lwt_ppx js_of_ocaml-ppx js_of_ocaml-ppx.deriving \
CLIENT_PACKAGES := lwt_log lwt_ppx js_of_ocaml-ppx js_of_ocaml-ppx.deriving \
ppx_deriving.std ocsigen-start.client base

# Automatically install packages via NPM
Expand Down

2 comments on commit d752ef3

@vouillon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. lwt_log does not make sense on the client. Server-side, eliom requires ocsigenserver, which requires lwt_log, so it should not be necessary either.

@vouillon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #528

Please sign in to comment.