Automated dependency upgrades #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jerivas
reviewed
May 8, 2023
| "eslint-config-prettier": "^8.8.0", | ||
| "eslint-import-resolver-typescript": "^3.5.5", | ||
| "eslint-plugin-import": "^2.27.5", | ||
| "eslint-plugin-jest": "^27.2.1", | ||
| "eslint-plugin-prettier": "^4.2.1", | ||
| "eslint-plugin-simple-import-sort": "^10.0.0", | ||
| "jsdom": "^21.1.1", | ||
| "jsdom": "^22.0.0", |
There was a problem hiding this comment.
Are these changes important to us? From the release notes:
Node.js v16 is now the minimum supported version.
Removed support for running jsdom in the browser via a browserified bundle. This carried with it too much complexity, especially for our testing infrastructure, and a testing package we relied on was recently deprecated.
jerivas
approved these changes
May 8, 2023
jgerigmeyer
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full log: https://github.com/oddbird/polyfill-template/actions/runs/4912863876