Refactor setLive Method by Extracting Draftable Relations Logic #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Isolates the logic for replicating and associating draftable relations to a published model into a standalone method for improved readability and modularity - Enhances flexibility for future adjustments and custom use-cases
|
@oddvalue could you inform me when will be released? would be good to release as soon as you can :) |
|
@vildanbina this is now in v1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
setLivemethod by extracting the logic responsible for replicating and associating draftable relations with the published model into its own method. This change aims to improve the method's readability, maintainability, and extendibility for future enhancements and custom use-cases.Changes
replicateAndAssociateDraftableRelationswhich encapsulates the logic for handling draftable relations during the publishing process.setLivemethod to call the newly createdreplicateAndAssociateDraftableRelationsmethod, thereby simplifying its own logic and focusing on its primary responsibilities.