Fix bug with whitespaces in config files paths

odoo-plus · Jul 6, 2023 · 31235ac · 31235ac
1 parent 7b6b05e
commit 31235ac
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/odoo_tools/api/environment.py b/odoo_tools/api/environment.py
@@ -247,9 +247,9 @@ def addons_paths(self):
                 paths = config.get('options', 'addons_path')
 
             config_paths = set(
-                Path(path)
+                Path(path.strip())
                 for path in paths.split(',')
-                if path
+                if path.strip()
             )
 
             if len(config_paths) > 0 and not self.context.force_addons_lookup:

diff --git a/tests/test_env.py b/tests/test_env.py
@@ -87,6 +87,21 @@ def test_env_config_addons_path(tmp_path):
     assert env.addons_paths() == set()
 
 
+def test_env_config_whitespace_addons_path(tmp_path):
+    env = Environment()
+
+    env.context.odoo_rc = tmp_path / 'odoo.cfg'
+
+    with env.config():
+        env.set_config('addons_path', ",".join([f" {tmp_path}", ""]))
+
+    paths = env.addons_paths()
+    assert paths == {tmp_path}
+
+    env.context.force_addons_lookup = True
+    assert env.addons_paths() == set()
+
+
 def test_invalid_env(tmp_path):
     env = Environment()