Skip to content

[IMP] *: remove automated x_name field in auto_install mode #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[IMP] *: remove automated x_name field in auto_install mode #1262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions 3pl_logistic_company/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@
<record id="x_fee_rate_model" model="ir.model">
<field name="name">Fee Rate</field>
<field name="model">x_fee_rate</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_stock_history_model" model="ir.model">
<field name="name">Stock History</field>
<field name="model">x_stock_history</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions automobile/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
<field name="model">x_brands</field>
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions bike_shop/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="x_worksheet_template_model" model="ir.model">
<field name="model">x_worksheet_template</field>
<field name="name">Device Installation and Maintenance</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions billboard_rental/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="model_worksheet_template_2" model="ir.model">
<field name="name">Billboard Worksheet</field>
<field name="model">x_project_task_worksheet_template_2_studio</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions certification_organism/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="x_control_charging_station_ir_model_1" model="ir.model">
<field name="name">Installation Control of Residential Charging Stations</field>
<field name="model">x_control_charging_station</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
2 changes: 2 additions & 0 deletions coal_petroleum/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
<record id="model_worksheet_template_1" model="ir.model">
<field name="name">Coal Quality Analysis</field>
<field name="model">x_quality_check_worksheet_template_1_studio</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>

<record id="model_worksheet_template_2" model="ir.model">
<field name="name">Gas Quality Analysis</field>
<field name="model">x_quality_check_worksheet_template_2_studio</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
7 changes: 7 additions & 0 deletions condominium/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,38 @@
<field name="is_mail_activity" eval="True"/>
<field name="model">x_buildings</field>
<field name="name">Buildings</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_buildings_tags" model="ir.model">
<field name="model">x_buildings_tag</field>
<field name="name">Buildings Tags</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_properties_tags" model="ir.model">
<field name="model">x_properties_tag</field>
<field name="name">Properties Tags</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_properties_types" model="ir.model">
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="model">x_properties_types</field>
<field name="name">Properties Types</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="ratios_model" model="ir.model">
<field name="model">x_ratios</field>
<field name="name">Ratios</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_meter_reading" model="ir.model">
<field name="model">x_meter_reading</field>
<field name="name">Meter Reading</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_meters" model="ir.model">
<field name="model">x_meters</field>
<field name="name">Meters</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions electronic_store/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="x_project_task_worksheet_template_1_ir_model_1" model="ir.model">
<field name="name">Default Worksheet</field>
<field name="model">x_project_task_worksheet_template_1_studio</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions excise_management/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="excise_category" model="ir.model">
<field name="model">x_excise_category</field>
<field name="name">Excise Category</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions eyewear_shop/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@
<field name="model">x_res_partner_line</field>
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
2 changes: 2 additions & 0 deletions hvac_services/data/ir_models.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
<record id="x_project_task_worksheet_template" model="ir.model">
<field name="name">INST/MAIN/REPA Worksheet</field>
<field name="model">x_project_task_worksheet_template</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_new_devices" model="ir.model">
<field name="name">Add new devices</field>
<field name="model">x_new_devices</field>
<field name="transient" eval="True" />
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
3 changes: 3 additions & 0 deletions industry_real_estate/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,16 @@
<record id="model_meter_reading" model="ir.model">
<field name="model">x_meter_reading</field>
<field name="name">Meter Reading</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_meters" model="ir.model">
<field name="model">x_meters</field>
<field name="name">Meters</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="model_buildings" model="ir.model">
<field name="model">x_buildings</field>
<field name="name">Buildings</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
3 changes: 3 additions & 0 deletions non_profit_organization/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@
<field name="is_mail_activity" eval="True"/>
<field name="model">x_petition</field>
<field name="name">Petition</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_petition_tag_model" model="ir.model">
<field name="model">x_petition_tag</field>
<field name="name">Petition Tags</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_signature_model" model="ir.model">
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="model">x_signature</field>
<field name="name">Signature</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions real_estate/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="product_template_line_model" model="ir.model">
<field name="name">product_template_line</field>
<field name="model">x_product_template_line</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions solar_installation/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
<record id="x_project_task_worksheet_template_1_ir_model_1" model="ir.model">
<field name="name">Default Worksheet</field>
<field name="model">x_project_task_worksheet_template_1_studio</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
1 change: 1 addition & 0 deletions team_sports_club/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
<field name="name">Contribution</field>
<field name="model">x_contribution</field>
<field name="transient" eval="True"/>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>
7 changes: 7 additions & 0 deletions tests/test_generic/tests/test_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def _check_files_in_path(self, module):
self._check_fields(tree, file_name)
self._check_change_theme_method(tree, file_name)
self._check_dates_are_relative(tree, file_name)
self._check_model_has_no_field(tree, file_name)
self._check_static_values_in_inputs(tree, file_name)
if root.split('/')[-1] == 'data':
self._check_view_active(tree, file_name)
Expand Down Expand Up @@ -461,6 +462,12 @@ def _check_view_active(self, root, file_name):
file_name,
)

def _check_model_has_no_field(self, root, file_name):
for record in root.xpath("//record[@model='ir.model']"):
active_field = record.xpath(".//field[@name='field_id']/@eval")
if not active_field or active_field[0] != "[Command.clear()]":
_logger.warning("You forgot to empty fields of ir.model record (id=%s in data/%s).", record.get('id'), file_name,)

def _check_user_is_set(self, root, previous_records):
records = previous_records
for model in MODELS_WITH_USER_ID:
Expand Down
7 changes: 7 additions & 0 deletions veterinary_clinic/data/ir_model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,40 @@
<field name="model">x_pets</field>
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_pets_line_model_record" model="ir.model">
<field name="name">pets_line</field>
<field name="model">x_pets_line_model</field>
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_species_model" model="ir.model">
<field name="name">Species</field>
<field name="model">x_species</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_vaccine_model" model="ir.model">
<field name="name">Vaccines</field>
<field name="model">x_vaccines</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_vaccines_tag_model" model="ir.model">
<field name="name">Vaccines Tags</field>
<field name="model">x_vaccines_tag</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_illnesses_model" model="ir.model">
<field name="name">Illnesses</field>
<field name="model">x_illnesses</field>
<field name="is_mail_thread" eval="True"/>
<field name="is_mail_activity" eval="True"/>
<field name="field_id" eval="[Command.clear()]"/>
</record>
<record id="x_species_line_model" model="ir.model">
<field name="name">species_line</field>
<field name="model">x_species_line</field>
<field name="field_id" eval="[Command.clear()]"/>
</record>
</odoo>