[FIX] spreadsheet: add name to DUPLICATE_SHEET #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When duplicating sheet, the name was based on the translation of "Copy of", which would lead to divergent sheet name if multiple users had different locale. Task: 4640070
|
|
hokolomopo
reviewed
Apr 14, 2025
Comment on lines
+528
to
+531
| cmd.sheetNameTo = getDuplicateSheetName( | ||
| sheetNames[cmd.sheetId], | ||
| Object.values(sheetNames) | ||
| ); |
There was a problem hiding this comment.
getDuplicateSheetName uses translations, so we'll end up with the exact same issue with different users having different sheet names after the repair 🙈
| @@ -766,7 +766,7 @@ export class SheetPlugin extends CorePlugin<SheetState> implements SheetState { | |||
| this.history.update("sheetIdsMapName", sheetIdsMapName); | |||
| } | |||
|
|
|||
| private getDuplicateSheetName(sheetName: string) { | |||
There was a problem hiding this comment.
mostly duplicated with helpers of migration, is it really useful to have both ? same for getNextSheetName
| @@ -343,6 +343,7 @@ export interface DeleteSheetCommand extends SheetDependentCommand { | |||
| export interface DuplicateSheetCommand extends SheetDependentCommand { | |||
| type: "DUPLICATE_SHEET"; | |||
| sheetIdTo: UID; | |||
| sheetNameTo: string; | |||
There was a problem hiding this comment.
should also have an allowDispatch to make sure we don't have a duplicate sheet name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplicating sheet, the name was based on the
translation of "Copy of", which would lead to divergent sheet name if multiple users had different locale.
Task: 4640070
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4640070
review checklist