[FIX] OT: Fix chart commands OT #6078
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
force-pushed
the
16.0-fix-ot-chart-rar
branch
from
ce32653 to
3f27f7b
Compare
Currently, we transform chart ranges upon the addition/deletion of headers in a sheet regardless if the range belongs to the said sheet. e.g. - given a chart with a range A1:A3 on sheet1 and a second A1:A3 on sheet2 - delete a the second row of sheet1 Both ranges are transformed and set to A1:A2. There is a double issue with the range on sheet2. 1. it's range zone is updated 2. the sheet prefix is removed, meaning that it no longer points towards the same sheet! Task: 4717724
rrahir
force-pushed
the
16.0-fix-ot-chart-rar
branch
from
3f27f7b to
1ef25b6
Compare
hokolomopo
reviewed
Apr 11, 2025
Comment on lines
188
to
+189
| let dataRangeZone: UnboundedZone | undefined; | ||
| let sheetName: string | undefined; |
There was a problem hiding this comment.
Suggested change
| let dataRangeZone: UnboundedZone | undefined; | |
| let sheetName: string | undefined; | |
| let newDataRange: string | undefined; |
nitpick, that way we don't have to have two let variables hanging around
same in scorecard
src/plugins/core/chart.ts
Outdated
| @@ -100,6 +100,7 @@ export class ChartPlugin extends CorePlugin<ChartState> implements ChartState { | |||
| size: { width: fig.width, height: fig.height }, | |||
| definition: chart.getDefinition(), | |||
| sheetId: cmd.sheetIdTo, | |||
| sheetMap: this.getters.getSheetMap(), | |||
There was a problem hiding this comment.
We talked about filtering the map with only relevant sheet name to reduce the size. Is it annoying/not necessary ?
rrahir
force-pushed
the
16.0-fix-ot-chart-rar
branch
from
4306384 to
8112c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: 4717724
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 4717724
review checklist