[FIX] conditional format: huge revisions on copy/paste cf #6080
+155
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@robodoo fw=no |
|
Disabled forward-porting. |
hokolomopo
force-pushed
the
saas-17.4-fix-copy-paset-cf-adrm
branch
2 times, most recently
from
ba41f8d to
cd54719
Compare
|
idem #6079 (comment) |
hokolomopo
force-pushed
the
saas-17.4-fix-copy-paset-cf-adrm
branch
from
cd54719 to
7309523
Compare
|
@robodoo fw=default forward to un-duplicate the |
|
Waiting for CI to create followup forward-ports. |
When copy/pasting a conditional format, the revision had one ADD_CONDITIONAL_FORMAT command per copied cell. That lead to huge revisions if, for example, a whole column with a CF was copied. Now the revision only has a single ADD_CONDITIONAL_FORMAT command per modified CF. The exact same work was done for data validation rules. Task: 4718522
hokolomopo
force-pushed
the
saas-17.4-fix-copy-paset-cf-adrm
branch
from
7309523 to
c6ced14
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 14, 2025
When copy/pasting a conditional format, the revision had one ADD_CONDITIONAL_FORMAT command per copied cell. That lead to huge revisions if, for example, a whole column with a CF was copied. Now the revision only has a single ADD_CONDITIONAL_FORMAT command per modified CF. The exact same work was done for data validation rules. closes #6080 Task: 4718522 Signed-off-by: Vincent Schippefilt (vsc) <[email protected]>
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When copy/pasting a conditional format, the revision had one ADD_CONDITIONAL_FORMAT command per copied cell. That lead to huge revisions if, for example, a whole column with a CF was copied.
Now the revision only has a single ADD_CONDITIONAL_FORMAT command per modified CF.
The exact same work was done for data validation rules.
Task: 4718522
review checklist