[FIX] Spreadsheet: Fix scroll issues in mobile#6082
Closed
Conversation
Collaborator
|
|
rrahir
force-pushed
the
18.0-scroll-mobile-rar
branch
from
e4549b9 to
144566d
Compare
hokolomopo
reviewed
Apr 15, 2025
|
|
||
| const HorizontalScrollFactor = 1; | ||
|
|
||
| // TODO merge it with the stop scroll of lucas |
| @@ -7,6 +7,7 @@ import { GridPopover } from "../grid_popover/grid_popover"; | |||
| import { css, cssPropertiesToCss } from "../helpers/css"; | |||
Contributor
There was a problem hiding this comment.
Other commit seems useless, the isMobile helpers are never used
Comment on lines
+6
to
+8
| const verticalScrollFactor = 1; | ||
|
|
||
| const HorizontalScrollFactor = 1; |
Contributor
There was a problem hiding this comment.
These factors seem useless is the value is 1 ?
Collaborator
Author
There was a problem hiding this comment.
I kept them in case i should fine tune through the testing phase
|
|
||
| const verticalScrollFactor = 1; | ||
|
|
||
| const HorizontalScrollFactor = 1; |
Contributor
There was a problem hiding this comment.
Suggested change
| const HorizontalScrollFactor = 1; | |
| const horizontalScrollFactor = 1; |
or all caps.
rrahir
force-pushed
the
18.0-scroll-mobile-rar
branch
from
144566d to
9402c7e
Compare
Collaborator
LucasLefevre
left a comment
LucasLefevre
left a comment
There was a problem hiding this comment.
Looking good 👍
only a small question.
Comment on lines
+29
to
+30
| const clientX = ev instanceof MouseEvent ? ev.clientX : ev.touches[0].clientX; | ||
| const clientY = ev instanceof MouseEvent ? ev.clientY : ev.touches[0].clientY; |
Collaborator
There was a problem hiding this comment.
in which case is this a MouseEvent or a TouchEvent ?
Collaborator
Author
There was a problem hiding this comment.
good question, it should be a touchevent 100% of the time so that helper doesn't really make sense .. i'll loot into it
Collaborator
Author
There was a problem hiding this comment.
@LucasLefevre I removed the helper, it really was useless
Currently, the scroll via touch is barely supported and only on the grid overlay DOM element, which means that you cannot scroll if you pass your finger on a figure for instance. This task tries to help out specifically in dashboard mode as there are no interactions with the different components (no drag and drop of components, grid selection, etc...); in edition mode, the mobile is still barely usable but this will be addressed in master considering the number of modifications required. Task: 4720073
rrahir
force-pushed
the
18.0-scroll-mobile-rar
branch
from
9402c7e to
5e4da6d
Compare
This was referenced Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, the scroll via touch is barely supported and only on the grid overlay DOM element, which means that you cannot scroll if you pass your finger on a figure for instance.
This task tries to help out specifically in dashboard mode as there are no interactions with the different components (no drag and drop of components, grid selection, etc...).
Task: 4720073
description of this task, what is implemented and why it is implemented that way.
Task: 4720073
review checklist