[IMP] add SELF evaluation to search method #516
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammarosano
force-pushed
the
alpha-search_eval-rcdl
branch
2 times, most recently
from
829c478 to
72b41d0
Compare
The base model's search method should have an evaluation of EvaluationSymbolPtr::SELF. This used to be the case, but it got lost in a refactor ([1]). [1]: ca26c3e
cammarosano
force-pushed
the
alpha-search_eval-rcdl
branch
from
72b41d0 to
37e4a52
Compare
mmahrouss
approved these changes
Jan 12, 2026
Collaborator
mmahrouss
left a comment
mmahrouss
left a comment
There was a problem hiding this comment.
Nice catch:) sorry it got lost in the refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base model's search method should have an evaluation of EvaluationSymbolPtr::SELF.
This used to be the case, but it got lost in a refactor (1).