Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website: introduce s_split_intro snippet #175321

Closed

Conversation

chgo-odoo
Copy link
Contributor

@chgo-odoo chgo-odoo commented Aug 1, 2024

This PR introduces a new snippet named s_split_intro.

image

task-4077616
Part of task-4077427


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Aug 1, 2024

Pull request status dashboard

@C3POdoo C3POdoo added the RD research & development, internal work label Aug 1, 2024
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch 2 times, most recently from 242928a to 44c260e Compare August 1, 2024 14:09
@chgo-odoo chgo-odoo changed the title [IMP] website: introduce a new snippet s_connections [ADD] website: introduce s_connection snippet Aug 2, 2024
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch 4 times, most recently from 926fabb to 212e982 Compare August 6, 2024 14:17
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from 212e982 to 23bef06 Compare August 21, 2024 09:47
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch 2 times, most recently from 0021db9 to 12b72a7 Compare August 22, 2024 11:30
@chgo-odoo chgo-odoo changed the title [ADD] website: introduce s_connection snippet [IMP] website: introduce s_connection snippet Aug 22, 2024
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from 12b72a7 to 9c828ad Compare August 27, 2024 18:54
@chgo-odoo chgo-odoo changed the title [IMP] website: introduce s_connection snippet [IMP] website: introduce s_split_intro snippet Aug 27, 2024
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from 9c828ad to de12ef4 Compare August 27, 2024 19:18
Copy link
Contributor

@anso-odoo anso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @chgo-odoo, here are some comments

addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from de12ef4 to c391311 Compare September 11, 2024 11:44
@chgo-odoo chgo-odoo requested a review from anso-odoo September 11, 2024 15:10
@chgo-odoo
Copy link
Contributor Author

ty @anso-odoo can you check?

Copy link
Contributor

@anso-odoo anso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking for you. After that it looks like it will be fine 👍

addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from c391311 to 9e89d70 Compare September 19, 2024 07:06
Copy link
Contributor

@anso-odoo anso-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch 3 times, most recently from be78e80 to 3526a9e Compare October 8, 2024 07:04
@chgo-odoo chgo-odoo marked this pull request as ready for review October 8, 2024 08:37
@C3POdoo C3POdoo requested a review from a team October 8, 2024 08:39
@lebl-odoo
Copy link

Hi @chgo-odoo , just wondering why we don't left a blank link for "Discover more" (all intro snippets use this value as default link) instead of using /contactus

Nice snippet 🎉

@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from 3526a9e to b824cc7 Compare February 13, 2025 12:48
@chrisdt1998 chrisdt1998 self-requested a review February 13, 2025 13:58
@chrisdt1998
Copy link

Hello, just confirming this PR is ready to be reviewed? :)

@chgo-odoo
Copy link
Contributor Author

I confirm @chrisdt1998, thank you 👍

Copy link

@chrisdt1998 chrisdt1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review :)

addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
addons/website/views/snippets/snippets.xml Outdated Show resolved Hide resolved
addons/website/views/snippets/s_split_intro.xml Outdated Show resolved Hide resolved
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from b824cc7 to 80066c6 Compare February 14, 2025 10:19
@chgo-odoo
Copy link
Contributor Author

Hello @chrisdt1998 👋

I pushed the changes on top, it should be good now !

If it looks okay, let's wait for #184760 to land so we don't have to r+ this twice 😄

Copy link

@chrisdt1998 chrisdt1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Will r+ as soon as the other PR is through

@qsm-odoo
Copy link
Contributor

@robodoo delegate=chrisdt1998
@chrisdt1998

This commit introduces a new snippet named `s_split_intro`.

task-4077616
part of task-4077427
@chgo-odoo chgo-odoo force-pushed the master-new-snippets-connections-chgo branch from 80066c6 to 7067463 Compare February 17, 2025 08:23
@chrisdt1998
Copy link

@robodoo r+

robodoo pushed a commit that referenced this pull request Feb 17, 2025
This commit introduces a new snippet named `s_split_intro`.

task-4077616
part of task-4077427

closes #175321

Related: odoo/design-themes#876
Signed-off-by: Christopher du Toit (chto) <[email protected]>
robodoo pushed a commit to odoo/design-themes that referenced this pull request Feb 17, 2025
*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro,
bookstore, buzzy, cobalt, enark, kiddo, loftspace, monglia, nano, notes,
odoo_experts, orchid, real_estate, treehouse, vehicle, yes, zap.

This commit reviews the occurrences of `s_split_intro` snippet across
design themes.

task-4077616
part of task-4077427

closes #876

Related: odoo/odoo#175321
Signed-off-by: Christopher du Toit (chto) <[email protected]>
@robodoo robodoo added the 18.2 label Feb 17, 2025
@robodoo robodoo closed this Feb 17, 2025
lost-odoo pushed a commit to odoo-dev/odoo that referenced this pull request Feb 18, 2025
This commit introduces a new snippet named `s_split_intro`.

task-4077616
part of task-4077427

closes odoo#175321

Related: odoo/design-themes#876
Signed-off-by: Christopher du Toit (chto) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18.2 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants