-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] website: introduce s_split_intro
snippet
#175321
[IMP] website: introduce s_split_intro
snippet
#175321
Conversation
242928a
to
44c260e
Compare
s_connections
s_connection
snippet
926fabb
to
212e982
Compare
212e982
to
23bef06
Compare
0021db9
to
12b72a7
Compare
s_connection
snippets_connection
snippet
12b72a7
to
9c828ad
Compare
s_connection
snippets_split_intro
snippet
9c828ad
to
de12ef4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @chgo-odoo, here are some comments
de12ef4
to
c391311
Compare
ty @anso-odoo can you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking for you. After that it looks like it will be fine 👍
c391311
to
9e89d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
be78e80
to
3526a9e
Compare
Hi @chgo-odoo , just wondering why we don't left a blank link for "Discover more" (all intro snippets use this value as default link) instead of using /contactus Nice snippet 🎉 |
3526a9e
to
b824cc7
Compare
Hello, just confirming this PR is ready to be reviewed? :) |
I confirm @chrisdt1998, thank you 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review :)
b824cc7
to
80066c6
Compare
Hello @chrisdt1998 👋 I pushed the changes on top, it should be good now ! If it looks okay, let's wait for #184760 to land so we don't have to r+ this twice 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Will r+ as soon as the other PR is through
@robodoo delegate=chrisdt1998 |
This commit introduces a new snippet named `s_split_intro`. task-4077616 part of task-4077427
80066c6
to
7067463
Compare
@robodoo r+ |
This commit introduces a new snippet named `s_split_intro`. task-4077616 part of task-4077427 closes #175321 Related: odoo/design-themes#876 Signed-off-by: Christopher du Toit (chto) <[email protected]>
*: anelusia, artists, avantgarde, aviato, beauty, bewise, bistro, bookstore, buzzy, cobalt, enark, kiddo, loftspace, monglia, nano, notes, odoo_experts, orchid, real_estate, treehouse, vehicle, yes, zap. This commit reviews the occurrences of `s_split_intro` snippet across design themes. task-4077616 part of task-4077427 closes #876 Related: odoo/odoo#175321 Signed-off-by: Christopher du Toit (chto) <[email protected]>
This commit introduces a new snippet named `s_split_intro`. task-4077616 part of task-4077427 closes odoo#175321 Related: odoo/design-themes#876 Signed-off-by: Christopher du Toit (chto) <[email protected]>
This PR introduces a new snippet named
s_split_intro
.s_split_intro
snippet design-themes#876task-4077616
Part of task-4077427
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr