Skip to content

PALM HACKS #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

PALM HACKS #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2557650
vaev-engine: Make table grid API simpler and better named.
pauloamed Aug 13, 2025
c67329e
vaev-engine: Refactor layout interface, shifting sizing and insets co…
pauloamed Aug 6, 2025
d5a1ca4
vaev-engine: Fit intrinsic sizing into the new layout api contract.
pauloamed Aug 13, 2025
6d26ad1
vaev-engine: Add support to table's border-collapse.
pauloamed Aug 18, 2025
586cacf
vaev-engine: Implement box-sizing in layout flow.
pauloamed Aug 19, 2025
8b320f2
vaev-engine: Fix removed from flow boxes not laid out in inline FC.
pauloamed Sep 9, 2025
66c6edc
vaev-engine: Add capmin parameter to width computation helpers.
pauloamed Sep 9, 2025
21059ac
vaev-engine: Compute and store table intrinsic sizes.
pauloamed Sep 9, 2025
ea7e9dd
end of the great rebase
Louciole Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/vaev-engine/driver/print.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ void _paintCornerMargin(Style::PageSpecifiedValues& pageStyle, Scene::Stack& sta
.root = Layout::buildForPseudoElement(pageStyle.area(area), currentPage, runningPosition),
.viewport = Layout::Viewport{.small = rect.size()}
};
auto [_, frag] = Layout::layoutCreateFragment(
auto [_, frag] = Layout::layoutAndCommitRoot(
tree,
{
.knownSize = rect.size().cast<Opt<Au>>(),
Expand All @@ -46,7 +46,7 @@ void _paintMainMargin(Style::PageSpecifiedValues& pageStyle, Scene::Stack& stack
.root = std::move(box),
.viewport = Layout::Viewport{.small = rect.size()}
};
auto [_, frag] = Layout::layoutCreateFragment(
auto [_, frag] = Layout::layoutAndCommitRoot(
tree,
{
.knownSize = rect.size().cast<Opt<Au>>(),
Expand Down Expand Up @@ -162,7 +162,7 @@ Pair<Vec<Layout::Breakpoint>, Vec<PageLayoutInfos>> collectBreakPointsAndRunning
pageLayoutInput.runningPosition = {&runningPosition};
context.contentTree.fc.enterDiscovery();

auto outDiscovery = Layout::layout(
auto outDiscovery = Layout::layoutRoot(
context.contentTree,
pageLayoutInput.withBreakpointTraverser(Layout::BreakpointTraverser(&prevBreakpoint))
);
Expand Down Expand Up @@ -233,7 +233,7 @@ export Generator<Print::Page> print(Gc::Ref<Dom::Document> dom, Print::Settings
.containingBlock = infos.pageContent.size(),
.pageNumber = pageNumber,
};
auto [outFragmentation, fragment] = Layout::layoutCreateFragment(
auto [outFragmentation, fragment] = Layout::layoutAndCommitRoot(
contentTree,
pageLayoutInput
.withBreakpointTraverser(Layout::BreakpointTraverser(&breakpoints[pageNumber], &breakpoints[pageNumber + 1]))
Expand Down
2 changes: 1 addition & 1 deletion src/vaev-engine/driver/render.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export RenderResult render(Gc::Ref<Dom::Document> dom, Style::Media const& media
viewport
};

auto [outDiscovery, root] = Layout::layoutCreateFragment(
auto [outDiscovery, root] = Layout::layoutAndCommitRoot(
tree,
{
.knownSize = {viewport.small.width, NONE},
Expand Down
Loading
Loading