Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark #7

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Benchmark #7

wants to merge 5 commits into from

Conversation

oduameh
Copy link
Owner

@oduameh oduameh commented Jul 8, 2024


  • CHANGELOG updated or not needed
  • Documentation updated or not needed
  • Haddocks updated or not needed
  • No new TODOs introduced or explained herafter

This comment was marked as off-topic.

Copy link

github-actions bot commented Jul 8, 2024

Test Results

437 tests  ±0   425 ✅ ±0   16m 29s ⏱️ +38s
143 suites ±0    12 💤 ±0 
  5 files   ±0     0 ❌ ±0 

Results for commit b5f2db3. ± Comparison against base commit 384fd04.

♻️ This comment has been updated with latest results.

@olgahryniuk
Copy link
Collaborator

For some reason, I cannot find certain files in the repo. The benchmarks folder does not include all the child sections visible on the docs site.

The following changes need to be applied before merging please:
Second file: 'Plutus Merkle tree contract'; 'On-chain Merkle tree costs'
Third file: 'Transaction costs'; '...the actual script is unique per head'; 'Init transaction costs'; 'Commit transaction costs'; 'This uses ada-only outputs for better comparability.' 'CollectCom transaction costs'; 'Close transaction costs'; 'Contest transaction costs'; 'Abort transaction costs'; 'There is some variation due to the random mixture of initial and already committed outputs.'; 'FanOut transaction costs'.
Fourth file: 'End-to-end benchmark results', 'This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.'; 'Please note that these results are approximate, as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.'; 'Baseline scenario'.

The final folder should be renamed to 'Test results'.

@oduameh
Copy link
Owner Author

oduameh commented Jul 9, 2024

For some reason, I cannot find certain files in the repo. The benchmarks folder does not include all the child sections visible on the docs site.

The following changes need to be applied before merging please: Second file: 'Plutus Merkle tree contract'; 'On-chain Merkle tree costs' Third file: 'Transaction costs'; '...the actual script is unique per head'; 'Init transaction costs'; 'Commit transaction costs'; 'This uses ada-only outputs for better comparability.' 'CollectCom transaction costs'; 'Close transaction costs'; 'Contest transaction costs'; 'Abort transaction costs'; 'There is some variation due to the random mixture of initial and already committed outputs.'; 'FanOut transaction costs'. Fourth file: 'End-to-end benchmark results', 'This page is intended to collect the latest end-to-end benchmark results produced by Hydra's continuous integration (CI) system from the latest master code.'; 'Please note that these results are approximate, as they are currently produced from limited cloud VMs and not controlled hardware. Rather than focusing on the absolute results, the emphasis should be on relative results, such as how the timings for a scenario evolve as the code changes.'; 'Baseline scenario'.

The final folder should be renamed to 'Test results'.

Hi @olgahryniuk that is true, most of the files are not in the benchmark folder, most of the files are embedded in the dev file as partial markdown scripts, which was why I had to revert the changes I made in those sections.

I will make the other changes you have highlighted. Also, did you mean changing the final folder from "Test Results" to "Test results" ?

@olgahryniuk
Copy link
Collaborator

Yes, Emmanuel, that's correct. As long as you just change some wording/letters without messing with scripts, it should work. Thank you

@olgahryniuk
Copy link
Collaborator

I don't see a commit renaming 'Test Results' to 'Test results'. Can you please address this?

This comment was marked as off-topic.

@oduameh oduameh force-pushed the master branch 2 times, most recently from 0d5b516 to 3e7bd6b Compare July 17, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants